Skip to content
This repository was archived by the owner on Apr 6, 2023. It is now read-only.

fix: allow extending middleware for declaration#4795

Closed
MichaelGitArt wants to merge 2 commits intonuxt:mainfrom
MichaelGitArt:feat/extend-middleware-types
Closed

fix: allow extending middleware for declaration#4795
MichaelGitArt wants to merge 2 commits intonuxt:mainfrom
MichaelGitArt:feat/extend-middleware-types

Conversation

@MichaelGitArt
Copy link
Copy Markdown

@MichaelGitArt MichaelGitArt commented May 4, 2022

🔗 Linked issue

#4794

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Extended middleware names are not in the types (middleware.d.ts).
This PR adds suggestions for definePageMeta for the middleware field if middleware is registered by module.

Resolves #4794

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@netlify
Copy link
Copy Markdown

netlify Bot commented May 4, 2022 •
edited
Loading

✅ Deploy Preview for nuxt3-docs canceled.

Name Link
🔨 Latest commit b881f6a
🔍 Latest deploy log https://app.netlify.com/sites/nuxt3-docs/deploys/62757ee76d59760009667199

@danielroe danielroe changed the title feat: add extened middleware names to middleware.d.ts fix: allow extending middleware for declaration May 6, 2022
@danielroe danielroe added bug Something isn't working dx 🍰 p2-nice-to-have Priority 2: nothing is broken but it's worth addressing labels May 6, 2022
@danielroe danielroe mentioned this pull request May 20, 2022
Merged
7 tasks
@pi0
Copy link
Copy Markdown
Member

pi0 commented May 20, 2022

Thanks for this PR @MichaelGitArt 💚 I believe changes in #5038 will remove the current hook but I let @danielroe to finalize and close if can confirm.

@danielroe
Copy link
Copy Markdown
Member

danielroe commented Jun 1, 2022

Yes, merging #5038 will remove the need for this PR - which was otherwise a great contribution!

@danielroe danielroe added the 3.x label Jan 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@danielroe danielroe danielroe approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

3.x bug Something isn't working dx 🍰 p2-nice-to-have Priority 2: nothing is broken but it's worth addressing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@MichaelGitArt @pi0 @danielroe